WIP: render author pages #1972

jjconti · 2015-08-24T14:30:20Z

Based on tags.py

Requires this configs:

AUTHOR_PATH = 'author'
AUTHOR_PAGES_ARE_INDEXES = True

and this messages:

"Authors": "Autores",
"Posts by %s": "Posts de %s"

Kwpolska · 2015-08-24T14:39:05Z

Great idea!

style fixes needed: https://travis-ci.org/getnikola/nikola/jobs/76990366#L171
tests fail. Add your new settings to conf.py.in and nikola.py, and messages to messages_en.py (we need some more work to get it to Transifex, we will handle that)
Would you mind implementing the title/description customization parts from tags?

da2x · 2015-08-24T14:54:56Z

Enhancement idea: Most CMS include short author bios and portrait images on these kind of pages. Maybe duplicate whats available in TAG_PAGES_DESCRIPTIONS as AUTHOR_PAGES_BIOS with the same format? and then the same for AUTHOR_PORTRAITS, I believe would work well.

“Guest authors” usually want a link back to their homepage from these kind of pages too … AUTHOR_HOMEPAGES? Or just make AUTHOR_PAGES_BIOS accept HTML blobs (TAG_PAGE_DESCRIPTIONS are just one paragraph of text).

jjconti · 2015-08-24T18:10:28Z

@Aeyoun interesting ideas, but with what I've implemented so far my requirements and available time are covered.

ralsina · 2015-08-24T18:17:18Z

@Aeyoun can you file those as a enhancement issue with a checklist? Once this is polished and merged we can tackle that as needed.

Kwpolska · 2015-08-24T18:52:56Z

nikola/conf.py.in

+# output / TRANSLATION[lang] / AUTHOR_PATH / index.html (list of tags)
+# output / TRANSLATION[lang] / AUTHOR_PATH / author.html (list of posts for a tag)
+# output / TRANSLATION[lang] / AUTHOR_PATH / author.xml (RSS feed for a tag)
+# TAG_PATH = "authors"


AUTHOR_PATH*

Kwpolska · 2015-08-24T18:53:29Z

nikola/data/themes/base/messages/messages_en.py

@@ -36,4 +36,6 @@
    "Write your post here.": "Write your post here.",
    "old posts, page %d": "old posts, page %d",
    "page %d": "page %d",
+    "Authors": "Authors",
+    "Posts by %s": "Posts by %s"


(we’ll need to copy that over to the .po file)

jjconti · 2015-08-24T19:18:32Z

For the docs:

You can link an author's page form you template adding this:

<a href="${_link('author', post.author())}">${post.author()}</a>

jjconti · 2015-08-24T19:18:57Z

A working example of this at: http://lugcos.github.io/

da2x · 2015-08-24T20:38:06Z

Issues #1973, #1974, and #1975.

Kwpolska · 2015-08-25T12:50:22Z

nikola/data/themes/base/templates/tag.tmpl

@@ -43,7 +43,8 @@
    %if posts:
    <ul class="postlist">
    % for post in posts:
-        <li><a href="${post.permalink()}" class="listtitle">${post.title()|h}</a> <time class="listdate" datetime="${post.formatted_date('webiso')}" title="${post.formatted_date(date_format)}">${post.formatted_date(date_format)}</time></li>
+        <li>


what changed here and why?

I improved the item visualization in the base tamplate. It was show as:
Title Date --- (dash)
The dash is added by the date style. I changed it to be
Date --- Title
as in other templates I saw. I used the same pattern in author.tmpl. Maybe there is an extra new line.

da2x · 2015-08-25T13:19:53Z

nikola/data/themes/base/templates/author.tmpl

+                    <a href="${_link(kind + "_rss", author, language)}" hreflang="${language}" type="application/rss+xml">${messages('RSS feed', language)} (${language})</a>&nbsp;
+                </p>
+                %endfor
+            %elif generate_rss:


Should be an generate_atom variant too here.

I didn't add it because tag.tmpl does not (no atom reference). tagindex.tmpl does and authorindex.tmpl does too.

da2x · 2015-08-25T13:24:29Z

Line 34 in data/themes/base/templates/post_header.tmpl should link to the author’s page if it is being generated. The enclosing span element can be replaced with an a element retaining the span’s microformats and adding rel="author me".

jjconti · 2015-08-31T00:33:22Z

I'll do it tonight when adding a final change. Thanks.

Conflicts: nikola/data/themes/base/messages/messages_en.py

…s more than one author

jjconti · 2015-08-31T03:04:52Z

I'm done. This can be merged (do I do it? am I getting commit access or something like that?).

NOTE: author*tmpl files are missing for base-jinja theme. I can add them after this is merged.

Kwpolska · 2015-08-31T07:49:48Z

I’ll merge it. If you want commit rights, just ask.
It can be generated with scripts/jinjify.py. I’ll handle that.

Thanks for your contribution!

WIP: render author pages

jjconti · 2015-08-31T11:19:32Z

You're welcome. Thanks for the software. I'll continue using it so I'll probably be doing more contributions.

Do we need to update CHANGELOG? Something in doc/? AUTHORS.txt?

Kwpolska · 2015-08-31T11:26:00Z

So, do you want commit rights or not?
CHANGES.txt, AUTHORS.txt and docs/manual.txt could use an update. Will you do it?

jjconti · 2015-08-31T11:28:10Z

Ok! I'll do it! :D I wasn't sure because of what Uncle Ben said[1] but, let's do it!

[1]Uncle Ben: Remember, with great power. comes great responsibility.

jjconti · 2015-08-31T15:25:38Z

Done.

#1972

WIP: render authors pages

c0efaef

Kwpolska added the enhancement label Aug 24, 2015

Kwpolska added this to the v7.6.5 milestone Aug 24, 2015

da2x added the PR exists label Aug 24, 2015

Juanjo Conti added 9 commits Aug 24, 2015

Fix style

124dcc5

Add AUTHOR* variables to config

63fd0ef

Fix

8d0baae

Use author description

ccf0820

Add author related tempaltes to base

07f0bb4

Add author tempalte to bootstrap3

8d80677

Fix tag template

2dbe15b

Update messages_en.py

be162a0

Remove pointless code

a8422d2

Juanjo Conti added 3 commits Aug 24, 2015

Fix key error

ad710b1

Remove unused imports

d58afc6

Fix style

e3e0b04

Kwpolska reviewed Aug 24, 2015
View changes

Fix

a594801

jjconti changed the title ~~WIP: render authors pages~~ WIP: render author pages Aug 24, 2015

Kwpolska reviewed Aug 25, 2015
View changes

da2x reviewed Aug 25, 2015
View changes

Juanjo Conti added 8 commits Aug 24, 2015

WIP: render authors pages

14ca39d

Fix style

5caf0c3

Add AUTHOR* variables to config

e75341e

Fix

f4fb9c8

Use author description

eb11672

Add author related tempaltes to base

7eaa217

Add author tempalte to bootstrap3

e2f9dac

Fix tag template

e8b4498

Juanjo Conti added 11 commits Aug 24, 2015

Update messages_en.py

2a0f5e8

Remove pointless code

c763177

Fix key error

7ed2db0

Remove unused imports

664a1b8

Fix style

be91d91

Fix

4de1133

Merge branch 'master' of github.com:jjconti/nikola

98d8973

Conflicts: nikola/data/themes/base/messages/messages_en.py

Restore removed \n

1f47671

Add ENABLE_AUTHOR_PAGES conf

d9f3387

Only generate author pages if ENABLE_AUTHOR_PAGES is True and there i…

c0841d4

…s more than one author

Add author_pages_generated to global context to use it in tamplates

679ed98

Kwpolska added a commit that referenced this pull request Aug 31, 2015

Merge pull request #1972 from jjconti/master

d3b0263

WIP: render author pages

Kwpolska merged commit d3b0263 into getnikola:master Aug 31, 2015
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

continuous-integration/appveyor AppVeyor build succeeded
Details

jjconti added a commit that referenced this pull request Aug 31, 2015

Add myself after PR #1972 got merged

bc87d26

Kwpolska added a commit that referenced this pull request Aug 31, 2015

Update manual.txt

d73ed1b

#1972

getnikola / nikola Public

WIP: render author pages #1972

WIP: render author pages #1972

jjconti commented Aug 24, 2015

Kwpolska commented Aug 24, 2015

da2x commented Aug 24, 2015

jjconti commented Aug 24, 2015

ralsina commented Aug 24, 2015

This comment has been minimized.

This comment has been minimized.

jjconti commented Aug 24, 2015

jjconti commented Aug 24, 2015

da2x commented Aug 24, 2015

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

da2x commented Aug 25, 2015

jjconti commented Aug 31, 2015

jjconti commented Aug 31, 2015

Kwpolska commented Aug 31, 2015

jjconti commented Aug 31, 2015

Kwpolska commented Aug 31, 2015

jjconti commented Aug 31, 2015

jjconti commented Aug 31, 2015

getnikola / nikola Public

WIP: render author pages #1972

WIP: render author pages #1972

Conversation

jjconti commented Aug 24, 2015

Kwpolska commented Aug 24, 2015

da2x commented Aug 24, 2015

jjconti commented Aug 24, 2015

ralsina commented Aug 24, 2015

This comment has been minimized.

Kwpolska Aug 24, 2015 Member

This comment has been minimized.

Kwpolska Aug 24, 2015 Member

jjconti commented Aug 24, 2015

jjconti commented Aug 24, 2015

da2x commented Aug 24, 2015

This comment has been minimized.

Kwpolska Aug 25, 2015 Member

This comment has been minimized.

jjconti Aug 25, 2015 Author Contributor

This comment has been minimized.

da2x Aug 25, 2015 Contributor

This comment has been minimized.

jjconti Aug 29, 2015 Author Contributor

da2x commented Aug 25, 2015

jjconti commented Aug 31, 2015

jjconti commented Aug 31, 2015

Kwpolska commented Aug 31, 2015

jjconti commented Aug 31, 2015

Kwpolska commented Aug 31, 2015

jjconti commented Aug 31, 2015

jjconti commented Aug 31, 2015

Kwpolska Aug 24, 2015
Member

Kwpolska Aug 24, 2015
Member

Kwpolska Aug 25, 2015
Member

jjconti Aug 25, 2015
Author Contributor

da2x Aug 25, 2015
Contributor

jjconti Aug 29, 2015
Author Contributor