Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds THEME_COLORS, POSTS_CATEGORIES, POSTS_CATEGORY_*, and HUSL color functions #1981

Merged
merged 22 commits into from Aug 31, 2015

Conversation

@da2x
Copy link
Contributor

@da2x da2x commented Aug 27, 2015

See Issue #1980 before proceeding.

Colors are not displayed anywhere just yet, except by adding a <meta name="theme-color">.

@@ -89,6 +89,10 @@ NAVIGATION_LINKS = ${NAVIGATION_LINKS}
# Name of the theme to use.
THEME = ${THEME}

# Primary color of your theme. This will be used to customize your theme and
# auto-generate related colors in POSTS_CATEGORY_COLORS. Must be a HEX value.
THEME_COLOR = '#5670d4'
Copy link
Member

@Kwpolska Kwpolska Aug 27, 2015

why this color?

Copy link
Contributor Author

@da2x da2x Aug 27, 2015

Generic light corporate blue were designed to be non-offensive and enduce trust. Sounds like a perfect candidate for a nonintrusive default if I ever heard one. Goes well with the default bootstrap3 theme. Feel free to suggest another.

@da2x
Copy link
Contributor Author

@da2x da2x commented Aug 27, 2015

@ralsina, @Kwpolska what do you guys think?

# is assigned to each category based on shifting the hue of your THEME_COLOR
# at least 7.5 % while leaving the lightness and saturation untouched in the
# HUSL colorspace. You can overwrite colors by assigning them colors in HEX.
POSTS_CATEGORY_COLORS = {
Copy link
Member

@Kwpolska Kwpolska Aug 28, 2015

should be commented out by default, along with POST_CATEGORY_DESCRIPTIONS and POST_CATEGORY_TITLE

@da2x
Copy link
Contributor Author

@da2x da2x commented Aug 29, 2015

I think it should be ready to merge now.

@da2x
Copy link
Contributor Author

@da2x da2x commented Aug 30, 2015

@ralsina have you got any time to look through this before merging?

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 30, 2015

Tomorrow morning I will.

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 30, 2015

LGTM. However, since sections is a new concept it needs documenting. I can do it myself since you already did the hard work of actually implementing them :-)

da2x added a commit that referenced this issue Aug 31, 2015
Add Sections and related color functionality for theme authors
@da2x da2x merged commit 0b24500 into master Aug 31, 2015
1 of 3 checks passed
@da2x da2x self-assigned this Aug 31, 2015
@Kwpolska Kwpolska deleted the posts-categories branch Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants