Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1983 #1998

Merged
merged 4 commits into from Sep 3, 2015
Merged

Fix 1983 #1998

merged 4 commits into from Sep 3, 2015

Conversation

@ralsina
Copy link
Member

ralsina commented Sep 2, 2015

Make tabcompletion work outside sites.

ralsina added 2 commits Sep 2, 2015
@@ -359,7 +360,7 @@ def run(self, cmd_args):
LOGGER.info('Did you mean "{}" or "{}"?'.format('", "'.join(best_sugg[:-1]), best_sugg[-1]))
return 3

if sub_cmds[args[0]] is not Help and not isinstance(sub_cmds[args[0]], Command): # Is a doit command
if not sub_cmds[args[0]] in (Help, Command, TabCompletion):

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Sep 2, 2015

Member

This won’t work, in won’t catch Command subclasses.

ralsina added 2 commits Sep 2, 2015
ralsina added a commit that referenced this pull request Sep 3, 2015
Fix 1983
@ralsina ralsina merged commit 7be07e8 into master Sep 3, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the fix-1983 branch Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.