Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2011 #2013

Merged
merged 1 commit into from Sep 4, 2015
Merged

Fix #2011 #2013

merged 1 commit into from Sep 4, 2015

Conversation

@jjconti
Copy link
Contributor

@jjconti jjconti commented Sep 4, 2015

No description provided.

Juanjo Conti
@humitos

This comment has been minimized.

Copy link
Member

@humitos humitos commented on nikola/data/themes/base/templates/list.tmpl in 1d4ee20 Sep 4, 2015

if you have 0 post for some year/month it won't show the number between brackets: (0). Is that ok for you?

This comment has been minimized.

Copy link
Contributor

@jjconti jjconti replied Sep 4, 2015

I think if there is 0 post for a month, the month is not even shown.

This comment has been minimized.

Copy link
Member

@humitos humitos replied Sep 4, 2015

yeah, you are right... but, is that correct? I mean, to show maybe only two months of the year... or maybe nothing...

This comment has been minimized.

Copy link
Member

@Kwpolska Kwpolska replied Sep 4, 2015

That’s what Nikola always does and always did in archives. We show only the months that exist, and don’t even generate pages for missing months.

This comment has been minimized.

Copy link
Contributor

@jjconti jjconti replied Sep 4, 2015

@humitos years without posts are't listed either.

This comment has been minimized.

Copy link
Member

@Kwpolska Kwpolska replied Sep 4, 2015

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 4, 2015

what about _generate_posts_task for daily archives?

@jjconti
Copy link
Contributor Author

@jjconti jjconti commented Sep 4, 2015

_generate_posts_task calls _prepare_task with items = None

@@ -8,8 +8,11 @@
</header>
%if items:
<ul class="postlist">
% for text, link in items:
% for text, link, count in items:

This comment has been minimized.

@Kwpolska

Kwpolska Sep 4, 2015
Member

other lists might not contain the count thing, you should look into that (in self.site.generic_post_list_renderer?)

This comment has been minimized.

@jjconti

jjconti Sep 4, 2015
Author Contributor

I looked for uses of list.tmpl. That's why I added None as count element in indexes.py

This comment has been minimized.

@Kwpolska

Kwpolska Sep 4, 2015
Member

Okay, let’s merge this.

Kwpolska added a commit that referenced this pull request Sep 4, 2015
@Kwpolska Kwpolska merged commit 02b9068 into master Sep 4, 2015
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the archive_count branch Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants