Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing atom feed renderer for empty post lists. #2028

Merged
merged 1 commit into from Sep 6, 2015
Merged

Conversation

@felixfontein
Copy link
Contributor

felixfontein commented Sep 6, 2015

When the atom feed renderer is called with a empty post list, it crashes with an exception as it tries to call formatted_date of the last post object. Since it doesn't care about the post object, I moved most of the code of Post.formatted_date to utils and left a wrapper in Post which substitutes the post's date if it wasn't given.

@felixfontein felixfontein added the bug label Sep 6, 2015
@da2x

This comment has been minimized.

Copy link
Contributor

da2x commented Sep 6, 2015

LGTM.

Kwpolska added a commit that referenced this pull request Sep 6, 2015
Fixing atom feed renderer for empty post lists.
@Kwpolska Kwpolska merged commit f68bf4f into master Sep 6, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix-atom-renderer branch Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.