Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add locale handlers for month names and formatted dates. #2036

Merged
merged 3 commits into from Sep 8, 2015

Conversation

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Sep 8, 2015

See #2029.

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Sep 8, 2015

First try to implement the ideas sketched in #2029, not really tested yet though.

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Sep 8, 2015

Now tested it, works fine!

@ralsina
Copy link
Member

@ralsina ralsina commented Sep 8, 2015

To keep API compatibility for plugins that may be calling it, could you keep utils.formatted_date that just wraps LocaleBorg.formatted_date?

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Sep 8, 2015

utils.formatted_date wasn't there until two (or so) days ago. I moved it there when fixing something in the Atom feed renderer.

@ralsina
Copy link
Member

@ralsina ralsina commented Sep 8, 2015

LGTM then

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Sep 8, 2015

Good, I'll merge then. I think now formatted_date found a good place in utils :)

felixfontein added a commit that referenced this issue Sep 8, 2015
Add locale handlers for month names and formatted dates. (fixes #2029)
@felixfontein felixfontein merged commit b0e9b64 into master Sep 8, 2015
3 checks passed
@felixfontein felixfontein deleted the add-locale-handlers branch Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants