Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making path handlers of indexes plugin work before get_tasks() is run. #2047

Merged
merged 4 commits into from Sep 13, 2015

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Sep 9, 2015

Fixes #2040.

site.register_path_handler('index', self.index_path)
site.register_path_handler('index_atom', self.index_atom_path)
site.register_path_handler('section_index', self.index_section_path)
site.register_path_handler('section_index_atom', self.index_section_atom_path)
return super(Indexes, self).set_site(site)

def _get_filtered_posts(self, lang, show_untranslated_posts):
Copy link
Member

@Kwpolska Kwpolska Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function name should be more informative. Also, using _underscores is not a valid reason to skip documenting things.

Copy link
Contributor Author

@felixfontein felixfontein Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that pep257 tool doesn't complain about missing docstrings for underscore names apparently. Good to know.

Copy link
Member

@Kwpolska Kwpolska Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It believes they are private, which often makes sense, but it’s good to throw in a docstring nevertheless.

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Sep 10, 2015

The failed check is due to some invariance breaking, which seems to not be the fault of this PR.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 11, 2015

@Aeyoun, mind reviewing and merging?

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Sep 12, 2015

Anyone minds if I merge?

Kwpolska added a commit that referenced this issue Sep 13, 2015
Making path handlers of indexes plugin work before get_tasks() is run.
@Kwpolska Kwpolska merged commit c370d97 into master Sep 13, 2015
2 of 3 checks passed
@Kwpolska Kwpolska deleted the fix-indexes branch Sep 13, 2015
@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Sep 13, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants