Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #2069 -- proper locale support for section links #2070
Conversation
Kwpolska
added
bug
i18n
labels
Sep 11, 2015
Kwpolska
assigned
da2x
Sep 11, 2015
Kwpolska
added this to the 7.7.1 milestone
Sep 11, 2015
felixfontein
reviewed
Sep 11, 2015
| @@ -745,11 +745,16 @@ def section_color(self, lang=None): | ||
| def section_link(self, lang=None): |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
felixfontein
Sep 11, 2015
Contributor
Why isn't this simply using the index_section_path path handler of the indexes plugin?
felixfontein
Sep 11, 2015
Contributor
Why isn't this simply using the index_section_path path handler of the indexes plugin?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kwpolska
Sep 12, 2015
Member
That’s a good question. I just fixed the existing code (by @Aeyoun). I looked a bit further, and it seems that the Post class does not have access to the Nikola site object, and therefore cannot talk to site.link() nor to the plugin manager.
Kwpolska
Sep 12, 2015
Member
That’s a good question. I just fixed the existing code (by @Aeyoun). I looked a bit further, and it seems that the Post class does not have access to the Nikola site object, and therefore cannot talk to site.link() nor to the plugin manager.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
felixfontein
Sep 13, 2015
Contributor
Maybe we should deprecate this function and encourate people to use site.link() instead. A Post object should know as little as possible about what other plugins are producing (well, except the pages and the posts plugins).
felixfontein
Sep 13, 2015
Contributor
Maybe we should deprecate this function and encourate people to use site.link() instead. A Post object should know as little as possible about what other plugins are producing (well, except the pages and the posts plugins).
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ralsina
Sep 15, 2015
Member
+1 to just using link. We don't need to have the post access the Nikola object either, links just need to be resolved after they are written in the document, when copying to output. In the meantime, link://foo/bar IS a valid and awesome link for us ;-)
ralsina
Sep 15, 2015
Member
+1 to just using link. We don't need to have the post access the Nikola object either, links just need to be resolved after they are written in the document, when copying to output. In the meantime, link://foo/bar IS a valid and awesome link for us ;-)
Kwpolska
merged commit 1c74d59
into
master
Sep 15, 2015
added a commit
that referenced
this pull request
Sep 15, 2015
Kwpolska commentedSep 11, 2015
This is #2069.
cc @Aeyoun, @ralsina.
Signed-off-by: Chris Warrick kwpolska@gmail.com