Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML escape in more places #2073

Merged
merged 3 commits into from Sep 12, 2015
Merged

HTML escape in more places #2073

merged 3 commits into from Sep 12, 2015

Conversation

@msnoigrs
Copy link
Contributor

@msnoigrs msnoigrs commented Sep 12, 2015

No description provided.

@@ -130,8 +129,3 @@ def template_deps(self, template_name):
deps += self.template_deps(fname)
self.cache[template_name] = tuple(deps)
return list(self.cache[template_name])


def striphtml(text):
Copy link
Contributor

@da2x da2x Sep 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this in place. Even if we don’t use it by default. It can be useful in some contexts and we don’t know exactly what every theme author will want to do. Also, removing it will break all existing themes. Yikes.

Loading

@da2x
Copy link
Contributor

@da2x da2x commented Sep 12, 2015

Nice that we consistently use |h everywhere.

Loading

@msnoigrs
Copy link
Contributor Author

@msnoigrs msnoigrs commented Sep 12, 2015

Thank you for checking.

Loading

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 12, 2015

I think we can merge this, any objections?

Loading

Kwpolska added a commit that referenced this issue Sep 12, 2015
@Kwpolska Kwpolska merged commit 666459e into getnikola:master Sep 12, 2015
2 checks passed
Loading
@msnoigrs msnoigrs deleted the htmlescape branch Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants