Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option FEED_PREVIEWIMAGE includes post previewimage meta #2100

Merged
merged 18 commits into from Sep 20, 2015

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Sep 18, 2015

Issue #2095.

Checks to see if the previewimage is found in the content before including it. Avoids duplicate imagery. <figure><img></figure> is recommended by Flipboard and supported by Apple News and Feedly. There is very little we can do about optimizing here as every feed consumer recommends different file formats, sizes, markup, and whatnot.

  • Deprecated RSS_PLAIN in favor of FEED_PLAIN for Atom and RSS
  • Deprecated RSS_TEASERS in favor of FEED_TEASER for Atom and RSS

da2x added 3 commits Sep 18, 2015
…2095)

Checks to see if the previewimage is found in the content before
including it. Avoids duplicate imagery. <figure><img></figure> is
recommended by Flipboard and supported by Apple News and Feedly.

* Deprecated RSS_PLAIN in favor of FEED_PLAIN for Atom and RSS
* Deprecated RSS_TEASERS in favor of FEED_TEASER for Atom and RSS
* Hi mom
@Kwpolska
Copy link
Member

Kwpolska commented Sep 18, 2015

What about RSS_READ_MORE_LINK?

Chris Warrick https://chriswarrick.com/
Sent from my Galaxy S3.
On 18 Sep 2015 03:18, "Daniel Aleksandersen" notifications@github.com
wrote:

Issue #2095 #2095.

Checks to see if the previewimage is found in the content before
including it. Avoids duplicate imagery.
is
recommended by Flipboard and supported by Apple News and Feedly.

  • Deprecated RSS_PLAIN in favor of FEED_PLAIN for Atom and RSS
  • Deprecated RSS_TEASERS in favor of FEED_TEASER for Atom and RSS

You can view, comment on, or merge this pull request online at:

#2100
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2100.

@Kwpolska
Copy link
Member

Kwpolska commented Sep 18, 2015

Also, why is this an option? We could probably just force it on everyone.
Most people won't mind.

Chris Warrick https://chriswarrick.com/
Sent from my Galaxy S3.
On 18 Sep 2015 07:13, "Chris Warrick" kwpolska@gmail.com wrote:

What about RSS_READ_MORE_LINK?

Chris Warrick https://chriswarrick.com/
Sent from my Galaxy S3.
On 18 Sep 2015 03:18, "Daniel Aleksandersen" notifications@github.com
wrote:

Issue #2095 #2095.

Checks to see if the previewimage is found in the content before
including it. Avoids duplicate imagery.
is
recommended by Flipboard and supported by Apple News and Feedly.

  • Deprecated RSS_PLAIN in favor of FEED_PLAIN for Atom and RSS
  • Deprecated RSS_TEASERS in favor of FEED_TEASER for Atom and RSS

You can view, comment on, or merge this pull request online at:

#2100
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2100.

@da2x
Copy link
Contributor Author

da2x commented Sep 18, 2015

What about RSS_READ_MORE_LINK?

Considering removing it again. Last year, all the big sites were doing this. Now, no one is doing it anymore and I can’t figure out why they stopped.

Also, why is this an option?

Some sites may include an img in their teasers already, depending on their site designs. Thought I’d give folks the options. Can flip the default to True, though.

@Kwpolska
Copy link
Member

Kwpolska commented Sep 18, 2015

Let’s:

  • leave both in
  • default to FEED_PREVIEWIMAGE = True
  • rename RSS_READ_MORE_LINK to FEED_READ_MORE_LINK and make sure it works in Atom, too

@da2x
Copy link
Contributor Author

da2x commented Sep 18, 2015

It does work with Atom. I’ll rename and change defaults. See I set the wrong default for FEED_PLAIN too.

da2x and others added 15 commits Sep 18, 2015
Replaced by FEED_READ_MORE_LINK and FEED_LINKS_APPEND_QUERY.
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
incompatible with pytest-cov

This reverts commit 24bf731.
…2095)

Checks to see if the previewimage is found in the content before
including it. Avoids duplicate imagery. <figure><img></figure> is
recommended by Flipboard and supported by Apple News and Feedly.

* Deprecated RSS_PLAIN in favor of FEED_PLAIN for Atom and RSS
* Deprecated RSS_TEASERS in favor of FEED_TEASER for Atom and RSS
* Hi mom
Replaced by FEED_READ_MORE_LINK and FEED_LINKS_APPEND_QUERY.
… into feed-previewimage

Conflicts:
	CHANGES.txt
da2x added a commit that referenced this pull request Sep 20, 2015
New option FEED_PREVIEWIMAGE includes post previewimage meta
@da2x da2x merged commit 24c86aa into master Sep 20, 2015
@Kwpolska Kwpolska deleted the feed-previewimage branch Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants