Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Deprecate `Post.section_link()`. #2111

Merged
merged 2 commits into from Sep 22, 2015

Conversation

Projects
None yet
2 participants
@felixfontein
Copy link
Contributor

felixfontein commented Sep 22, 2015

WIP for #2086.

Where should this go in CHANGES.txt? Is this a feature or a bug? :)

@@ -744,7 +744,7 @@ def section_color(self, lang=None):
return utils.colorize_str_from_base_color(slug, base)

def section_link(self, lang=None):
"""Return the link to the post's section."""
"""Return the link to the post's section (deprecated)."""
if lang is None:

This comment has been minimized.

@Kwpolska

Kwpolska Sep 22, 2015

Member

could use a deprecation warning (logger.warning if we can access that)

This comment has been minimized.

@felixfontein

felixfontein Sep 22, 2015

Author Contributor

utils.LOGGER is available.

@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented Sep 22, 2015

Add a different changelog section for this, at the end, named Deprecations, I guess?

Also, please make a commit with fix #2086 in the message.

Kwpolska added a commit that referenced this pull request Sep 22, 2015

Merge pull request #2111 from getnikola/deprecate-section-link
WIP: Deprecate `Post.section_link()`.

@Kwpolska Kwpolska merged commit 8840c71 into master Sep 22, 2015

0 of 3 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@Kwpolska Kwpolska deleted the deprecate-section-link branch Sep 22, 2015

@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented Sep 22, 2015

Thanks!

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

felixfontein commented Sep 22, 2015

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.