New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ghp import #2152

Merged
merged 2 commits into from Oct 30, 2015

Conversation

Projects
None yet
2 participants
@topiaruss
Copy link
Contributor

topiaruss commented Oct 21, 2015

In my use on OSX, python3, there were encoding issues in setup.py for the older ghp-import during pip install. ghp-import2 is supposed to fix that and other packaging issues so I'm hoping you can upgrade.

I've made the appropriate change in requirements-extras.txt, and tried to run tests. I immediately hit a problem related to parsing the results of locale -a, which are different on OSX, so fixed that issue.

I see other test failures due to temporary directories ('/var/folders') and hyphenator.

Can you test this PR in your environment, and merge it if it works for you. Sorry, don't have time to fix anymore tests at the moment.

@Kwpolska Kwpolska added this to the v7.7.3 milestone Oct 21, 2015

@Kwpolska Kwpolska self-assigned this Oct 21, 2015

@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented Oct 21, 2015

We don’t have any tests for ghp-import. Assuming nothing has changed with the invocation of ghp-import2, Nikola should work fine. Are you aware of any changes?

@topiaruss

This comment has been minimized.

Copy link
Contributor Author

topiaruss commented Oct 21, 2015

I'm not aware of changes, but neither have I exercised any related code. Perhaps you can find someone who uses github pages, and get them to run some tests.

Kwpolska added a commit that referenced this pull request Oct 30, 2015

@Kwpolska Kwpolska merged commit a14bcaf into getnikola:master Oct 30, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@topiaruss topiaruss deleted the topiaruss:update-ghp-import branch Oct 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment