Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for german special characters characters in slugify #2172

Closed
wants to merge 1 commit into from

Conversation

@akrist
Copy link

akrist commented Nov 15, 2015

No description provided.

@Kwpolska
Copy link
Member

Kwpolska commented Nov 15, 2015

👎

This cannot be merged as it stands. The letters ä/ö/ü are present in languages other than German. And those other languages don’t use (or even forbid) ae/oe/ue as the replacements. They might be fine with a/o/u, or have their own replacements.

The next idea would be “check the current language and act accordingly”. And this is complicated, because we use slugify a lot, and we might depend on its value not changing between runs (for example if we need to slugify a file name, and don’t have a list of slugifications made, which we don’t, especially over multiple runs of Nikola). Which would make things even worse.

I’m afraid I have to reject this.

(PS. ß is already slugified as ss.)

@Kwpolska Kwpolska closed this Nov 15, 2015
@da2x
Copy link
Contributor

da2x commented Nov 15, 2015

There is already a setting for using Unicode in slugs. Use that instead.

@felixfontein
Copy link
Contributor

felixfontein commented Nov 15, 2015

How about modifying Nikola that lang is passed to all calls of slugify (with by default getting it from LocaleBorg)? It might be harder to implement this, but I think it's worth trying.

@Kwpolska
Copy link
Member

Kwpolska commented Nov 15, 2015

How about no? It’s a really minor thing most people don’t care about, and we could still fuck up if we did not notice something using locale-dependent slugify where it’s inappropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.