Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PEP8 compliant #2184

Merged
merged 3 commits into from Dec 5, 2015
Merged

Make PEP8 compliant #2184

merged 3 commits into from Dec 5, 2015

Conversation

@habi
Copy link
Contributor

@habi habi commented Dec 4, 2015

As part of http://24pullrequests.com/ and to test the waters with the
Nikolai team

As part of http://24pullrequests.com/ and to test the waters with the
Nikolai team
dodo.py Outdated
@@ -11,7 +11,8 @@


def recursive_glob(path, pattern):
"""recursively walk path directories and return files matching the pattern"""
"""recursively walk path directories and return files matching the

This comment has been minimized.

@Kwpolska

Kwpolska Dec 5, 2015
Member

That does not match PEP257 though, which is another important standard.

dodo.py Outdated
@@ -41,7 +43,8 @@ def set_nikola_test_locales():
locales = []
languages = set()
for line in out.splitlines():
if (line.endswith('.utf8') or line.endswith('.UTF-8')) and '_' in line:
if (line.endswith('.utf8') or line.endswith('.UTF-8')) and \

This comment has been minimized.

@Kwpolska

Kwpolska Dec 5, 2015
Member

We prefer to use (parentheses) for continuations.

setup.py Outdated
@@ -90,7 +90,8 @@ def expands_symlinks_for_windows():
sys.path = oldpath
del sys.modules['winutils']
if failures != -1:
print('WARNING: your working copy is now dirty by changes in samplesite, sphinx and themes')
print('WARNING: your working copy is now dirty by changes in'
'samplesite, sphinx and themes')

This comment has been minimized.

@Kwpolska

Kwpolska Dec 5, 2015
Member

Missing a space between the two lines..

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Dec 5, 2015

Also, we don’t honor the 79 character limit.

@habi
Copy link
Contributor Author

@habi habi commented Dec 5, 2015

I've fixed the missing space and reverted changes in dodo.py.
Hope that still helps.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Dec 5, 2015

Yeah, thanks for your contribution! 👏

Kwpolska added a commit that referenced this pull request Dec 5, 2015
Make PEP8 compliant
@Kwpolska Kwpolska merged commit 7a6ba00 into getnikola:master Dec 5, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@habi
Copy link
Contributor Author

@habi habi commented Dec 5, 2015

Very welcome.
You mention that you don't honour the 79 characters limit.
I'll try to push some changes for pep8 */*.py --ignore=E501 if that's OK.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Dec 5, 2015

Actually, we already do that.

@habi
Copy link
Contributor Author

@habi habi commented Dec 5, 2015

Didn't see that yet. There are bunch of PEP8 errors in the tests folder. I'll fix them and make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.