Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2166 #2188

Merged
merged 2 commits into from Dec 20, 2015
Merged

fix #2166 #2188

merged 2 commits into from Dec 20, 2015

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Dec 18, 2015

Use a FS cache for jinja bytecode like we do for Mako.

@@ -52,7 +52,10 @@ def __init__(self):
"""Initialize Jinja2 environment with extended set of filters."""
if jinja2 is None:
return
self.lookup = jinja2.Environment()
# Not ideal because it's not using our cache structure
Copy link
Member

@Kwpolska Kwpolska Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it held then? If this is the case, couldn’t we handle this in create_lookup or set_site?

Loading

Copy link
Member Author

@ralsina ralsina Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the jinja docs "system temp folder". It looks like it needs to be set on env creation. Maybe we can delay that until set_site?

Loading

Copy link
Member Author

@ralsina ralsina Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can fix this.

Loading

Copy link
Member Author

@ralsina ralsina Dec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done I think.

Loading

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Dec 18, 2015

Merge if this does not break anything (test it yourself)

Loading

@ralsina ralsina merged commit c92f632 into master Dec 20, 2015
4 checks passed
Loading
@ralsina ralsina deleted the add-jinja-cache branch Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants