Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin shortcodes #2195

Merged
merged 6 commits into from Jan 4, 2016
Merged

Builtin shortcodes #2195

merged 6 commits into from Jan 4, 2016

Conversation

@ralsina
Copy link
Member

ralsina commented Dec 24, 2015

  • Adds nikola/data/shortcodes/templateenginename for "builtin" shortcodes
  • Loads those
  • Adds a raw shortcode
  • Use jinjify to translate shortcodes
@gour gour mentioned this pull request Dec 24, 2015
8 of 11 tasks complete
ralsina added 2 commits Dec 24, 2015
with open(os.path.join(sc_dir, fname)) as fd:
template_data = fd.read()

def render_shortcode(t_data=template_data, **kw):

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Dec 26, 2015

Member

Could this be better with functools.partial?

@@ -0,0 +1 @@
${data}

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Dec 26, 2015

Member

jinjify this

@Kwpolska
Copy link
Member

Kwpolska commented Dec 26, 2015

👍

ralsina added a commit that referenced this pull request Jan 4, 2016
Builtin shortcodes
@ralsina ralsina merged commit 1b620db into master Jan 4, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the builtin-shortcodes branch Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.