Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplistic implementation of data caching and persistance #2210

Merged
merged 16 commits into from Jan 29, 2016
Merged

Conversation

@ralsina
Copy link
Member

ralsina commented Jan 4, 2016

This implementation of data caching/persistence is intentionally simplistic. The parameters for the design were:

  1. It should provide reasonable diffs when you add/remove data
  2. Data should be typed
  3. Should support basic data types

So, what do you think?

Known problems:

  • To make this atomic, it needs slightly more complicated saving code. Since doit can run threaded, that's important.
  • In order not to miss saved data when using multiprocess mode, it may need to reload the file on each read / some reads, which makes it much more expensive.
@ralsina ralsina changed the title WIP: simplistic implementation of data caching and persistance simplistic implementation of data caching and persistance Jan 25, 2016
ralsina added 4 commits Jan 25, 2016
@ralsina
Copy link
Member Author

ralsina commented Jan 29, 2016

WTH let's merge this.

ralsina added a commit that referenced this pull request Jan 29, 2016
simplistic implementation of data caching and persistance
@ralsina ralsina merged commit a25b5ea into master Jan 29, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the persistent-state branch Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.