Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option post_type to post-list directive #2272

Merged
merged 1 commit into from Mar 2, 2016
Merged

Conversation

@davidak
Copy link
Contributor

@davidak davidak commented Feb 28, 2016

all possibilities tested (with python 3.5)

output = _do_post_list(start, stop, reverse, tags, categories, slugs, show_all,
lang, template, sort, state=self.state, site=self.site)
output = _do_post_list(start, stop, reverse, tags, categories, slugs, post_type,
show_all, lang, template, sort, state=self.state, site=self.site)

This comment has been minimized.

@Kwpolska

Kwpolska Feb 28, 2016
Member

Fix the indentation so that you follow PEP 8 (show_all directly under start)

@davidak davidak force-pushed the davidak:page-list branch from 671d3af to b210ad5 Feb 28, 2016
@davidak
Copy link
Contributor Author

@davidak davidak commented Feb 28, 2016

done.

flake8 nikola/ returns no warnings.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Feb 28, 2016

I’ll review it when I’ll have more time.

@ralsina
Copy link
Member

@ralsina ralsina commented Mar 2, 2016

LGTM

ralsina added a commit that referenced this pull request Mar 2, 2016
add option post_type to post-list directive
@ralsina ralsina merged commit 6c30cd6 into getnikola:master Mar 2, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ralsina
Copy link
Member

@ralsina ralsina commented Mar 2, 2016

Thanks for the PR @davidak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants