Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enclosure lengths so podcast RSS is valid for more/all readers #2338

Merged
merged 2 commits into from May 6, 2016

Conversation

@x1101
Copy link
Contributor

@x1101 x1101 commented May 6, 2016

Prior to this change, RSS XML generate included the enclosure URL, but a file length of "0". This causes many podcatchers to reject the feed. This resolves that issue.

@@ -293,9 +293,9 @@

def _enclosure(post, lang):
"""Add an enclosure to RSS."""
enclosure = post.meta('enclosure', lang)
enclosure = post.meta('enclosure_url', lang)

This comment has been minimized.

@Kwpolska

Kwpolska May 6, 2016
Member

Don’t change the name.

if enclosure:
length = 0
length = post.meta('enclosure_length', lang)

This comment has been minimized.

@Kwpolska

Kwpolska May 6, 2016
Member

Default to zero and use integers.

length = int(post.meta('enclosure_length', lang) or 0)
@x1101
Copy link
Contributor Author

@x1101 x1101 commented May 6, 2016

Applied cleanup as suggested.

@Kwpolska Kwpolska self-assigned this May 6, 2016
@Kwpolska Kwpolska added this to the v7.7.9 milestone May 6, 2016
@Kwpolska Kwpolska added the enhancement label May 6, 2016
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 6, 2016

Right, that’s still not enough. I’ll fix it myself and merge.

Thanks for your contribution!

PS. you may want to set your Git client to something else than Your full name for user.name.

@Kwpolska Kwpolska merged commit 8e71c41 into getnikola:master May 6, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 6, 2016

Merged and fixed in commit cfc8554.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.