Fixing #2347. #2348
Merged
Fixing #2347. #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
[ci skip] fix #2347
|
I updated the changelog for this. Also, in the future, please make sure to use “fix” or any of the other special closing keywords in commit messages (fix{,es,ed}, close{,s,d}, resolve{s,d}) so that GitHub closes the issue when this is merged (I did that in my changelog commit) |
|
Thanks for updating changelog! I keep forgetting that Github doesn't like "fixing" for that... Sorry :) |
|
LGTM |
|
Looks like we lost travis???? I see no test reports in this branch! |
|
GitHub doesn’t react well to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes message inheritance as described in #2347.