Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing #2347. #2348
Merged
Fixing #2347. #2348
Conversation
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
I updated the changelog for this. Also, in the future, please make sure to use “fix” or any of the other special closing keywords in commit messages (fix{,es,ed}, close{,s,d}, resolve{s,d}) so that GitHub closes the issue when this is merged (I did that in my changelog commit) |
This comment has been minimized.
This comment has been minimized.
|
Thanks for updating changelog! I keep forgetting that Github doesn't like "fixing" for that... Sorry :) |
This comment has been minimized.
This comment has been minimized.
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
Looks like we lost travis???? I see no test reports in this branch! |
This comment has been minimized.
This comment has been minimized.
|
GitHub doesn’t react well to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
felixfontein commentedMay 22, 2016
Fixes message inheritance as described in #2347.