Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #2347. #2348

Merged
merged 2 commits into from May 22, 2016
Merged

Fixing #2347. #2348

merged 2 commits into from May 22, 2016

Conversation

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented May 22, 2016

Fixes message inheritance as described in #2347.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 22, 2016

👍 from me, @ralsina?

@Kwpolska Kwpolska added this to the v7.7.9 milestone May 22, 2016
@Kwpolska Kwpolska added bug i18n labels May 22, 2016
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 22, 2016

I updated the changelog for this. Also, in the future, please make sure to use “fix” or any of the other special closing keywords in commit messages (fix{,es,ed}, close{,s,d}, resolve{s,d}) so that GitHub closes the issue when this is merged (I did that in my changelog commit)

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented May 22, 2016

Thanks for updating changelog! I keep forgetting that Github doesn't like "fixing" for that... Sorry :)

@ralsina
Copy link
Member

@ralsina ralsina commented May 22, 2016

LGTM

@ralsina
Copy link
Member

@ralsina ralsina commented May 22, 2016

Looks like we lost travis???? I see no test reports in this branch!

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 22, 2016

GitHub doesn’t react well to [ci skip] in PRs, it seems. Merging on the basis of the first commit building properly.

@Kwpolska Kwpolska merged commit da5e94c into master May 22, 2016
@Kwpolska Kwpolska deleted the fix-messages-inheritance branch May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants