Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect attempt to change ipynb template #2353

Merged
merged 1 commit into from Jun 4, 2016
Merged

Conversation

@punchagan
Copy link
Member

@punchagan punchagan commented May 30, 2016

The previous code intended to set the template to basic, but it doesn't
really work and the full template was being used.

@punchagan
Copy link
Member Author

@punchagan punchagan commented May 30, 2016

@damianavila Does this change look OK to you? It works fine for me.

@damianavila
Copy link
Member

@damianavila damianavila commented May 31, 2016

As long as we are not breaking the status quo, I am OK.
Originally the idea was to use the basic template so anyone can do their own stuff... BUT...
Which is the default experience if we turn this to actually use the basic template?
I don't want to break the current user experience in the default setup...

The previous code intended to set the template to basic, but it doesn't
really work and the full template is being used. But, since this is
already has a user base just removing the confusing line of code, and
not actually changing the template.
@punchagan punchagan force-pushed the fix-ipython-template branch from 364c756 to dddd9a8 Jun 1, 2016
@punchagan
Copy link
Member Author

@punchagan punchagan commented Jun 1, 2016

@damianavila Fair enough. I just removed the confusing line which attempts to change the template, but doesn't work.

Users can use IPYNB_CONFIG if they really want the basic template.

@punchagan punchagan changed the title BUG: Really use the basic ipynb export template Remove incorrect attempt to change ipynb template Jun 1, 2016
@Kwpolska Kwpolska merged commit 88f7071 into master Jun 4, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix-ipython-template branch Jun 4, 2016
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 4, 2016

Let’s merge this if the original was broken.

@punchagan
Copy link
Member Author

@punchagan punchagan commented Jun 4, 2016

Just to clarify, the PR now just removes the code which tries to change the template to basic, but doesn't work correctly. The full template will be used, and users can switch to basic template using the IPYNB_CONFIG setting.

@damianavila
Copy link
Member

@damianavila damianavila commented Jun 4, 2016

Yep, understood... I agree with the merge. Thanks @punchagan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants