Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal scrollbar to listings #2383

Merged
merged 1 commit into from Jun 30, 2016
Merged

Add horizontal scrollbar to listings #2383

merged 1 commit into from Jun 30, 2016

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Jun 27, 2016

This replaces code tables that would go beyond screen width with code tables that always have horizontal scrollbars. This is not a perfect solution, though — it looks uglier when there is no overflow:

image

There’s also overflow-x: overlay; which looks like this and partially covers text:

image

Which one is better for most users? Opinions welcome.

cc @iAmMrinal0 — via getnikola/nikola-themes#86 (pending)

@iAmMrinal0
Copy link
Contributor

iAmMrinal0 commented Jun 27, 2016

I prefer the first one. The main point of having a design is readability, which is hard in the second design even if it's a single line.

@felixfontein
Copy link
Contributor

felixfontein commented Jun 27, 2016

Aren't these horizontal scrolling bars?

@Kwpolska Kwpolska changed the title Add vertical scrollbar to listings Add horizontal scrollbar to listings Jun 27, 2016
@Kwpolska
Copy link
Member Author

Kwpolska commented Jun 27, 2016

Oops, one typo that went everywhere. Should be fixed everywhere.

Via getnikola/nikola-themes#86

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska force-pushed the listing-overflow branch from 9439405 to 537ec48 Jun 27, 2016
@Kwpolska
Copy link
Member Author

Kwpolska commented Jun 30, 2016

Merging.

@Kwpolska Kwpolska merged commit 970598a into master Jun 30, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the listing-overflow branch Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.