Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exif filtering (fixes #2323) #2396

Merged
merged 24 commits into from Jul 20, 2016
Merged

Add exif filtering (fixes #2323) #2396

merged 24 commits into from Jul 20, 2016

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jul 18, 2016

Missing:

  • Any sort of checking it works
  • Some images are just copied and bypass EXIF handling!
  • Docs
@ralsina ralsina changed the title WIP: Add exif filtering Add exif filtering (fixes #2323) Jul 19, 2016
@ralsina
Copy link
Member Author

@ralsina ralsina commented Jul 19, 2016

@Kwpolska if you can take a look and see if this makes sense, much appreciated.

def filter_exif(self, exif, whitelist):
"""Filter EXIF data as described in the documentation."""
self._fill_exif_tag_names()
exif = exif.copy() # Don't modify in-place, it's rude

This comment has been minimized.

@Kwpolska

Kwpolska Jul 19, 2016
Member

Optimize this by putting it after the first two ifs.

#
# For a full list of field names, please see here:
# http://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf

This comment has been minimized.

@Kwpolska

Kwpolska Jul 19, 2016
Member

Is there any nicer document available?

This comment has been minimized.

@ralsina

ralsina Jul 19, 2016
Author Member

I looked, and not really :-(

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 19, 2016

I’m not an Exif/photo expert, but LGTM as far as the code is concerned.

ralsina added 2 commits Jul 19, 2016
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 20, 2016

Feel free to merge.

@ralsina ralsina merged commit 241bfd6 into master Jul 20, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the add-exif-filtering branch Jul 20, 2016
@ralsina
Copy link
Member Author

@ralsina ralsina commented Jul 20, 2016

Thanks for checking it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants