Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EXTRA_THEMES_DIRS. #2429

Merged
merged 4 commits into from Aug 15, 2016
Merged

Added EXTRA_THEMES_DIRS. #2429

merged 4 commits into from Aug 15, 2016

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Aug 4, 2016

Implements a first version of EXTRA_THEMES_DIRS. Requires that site.plugins_dirs is passed to some theme-related functions in utils.py. This might break some other plugins outside this repository. (The ones in this repository are all adjusted accordingly.)

fixes #2427

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Aug 6, 2016

I've tested this a bit, works well for me so far.

What might be missing: example entry in conf.py. I'm kind of reluctant to add this yet as this feature might not work with some third-party plugins (yet). On the other hand, if this feature isn't documented properly enough, nobody will bother to add support to other plugins.

Any thoughts on this?

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 6, 2016

I am not sure about this. You seem to be passing THEMES_DIRS everywhere... how about chainging theme_chain so it keeps paths instead of theme names? That way you only need to pass it there and things should work.

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Aug 7, 2016

That would definitely simplify it. I'll look into it later.

…licit passing of themes_dirs in several places except where handling theme names is necessary.
@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Aug 7, 2016

Ok, I tried that. Seems to work. I hope no other plugin is assuming that site.THEMES contains the theme names.

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Aug 10, 2016

@ralsina: any more thoughts on this?

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 15, 2016

LGTM merging!

@ralsina ralsina merged commit 42a0b7f into master Aug 15, 2016
4 checks passed
@ralsina ralsina deleted the extra_themes_dirs branch Aug 15, 2016
@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Aug 15, 2016

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants