Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pygal chart options #2430

Merged
merged 3 commits into from Aug 8, 2016
Merged

Update Pygal chart options #2430

merged 3 commits into from Aug 8, 2016

Conversation

@andredias
Copy link
Contributor

@andredias andredias commented Aug 6, 2016

There are a few new Pygal 2.2.3 options that could be used in chart directive.

"css": directives.unchanged,
# "defs": directives.unchanged,

This comment has been minimized.

@Kwpolska

Kwpolska Aug 6, 2016
Member

Why is that commented out?

This comment has been minimized.

@andredias

andredias Aug 6, 2016
Author Contributor

I thought not to include this option because it should receive a multiline value and it is kind of hard to write in a rst directive. But it could be accomplished using '\n' and spaces. So it can be included after all. Should I provide another pull request?

This comment has been minimized.

@Kwpolska

Kwpolska Aug 6, 2016
Member

If you can get it to work, you can just push one more commit to your fork with this uncommented.

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 6, 2016

Also, please add a one-liner in CHANGES and yourself to AUTHORS if you are not already there :-)

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Aug 7, 2016

One more housekeeping request, it looks like your commit was misattributed. Please add the e-mail address you used (pronus dot io) for this commit to your GitHub profile so your commits will appear as yours.

Thanks!

andredias added 2 commits Aug 8, 2016
@Kwpolska Kwpolska merged commit 32cbb13 into getnikola:master Aug 8, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants