Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature images metadata #2438

Closed
wants to merge 11 commits into from
Closed

Conversation

@guyou
Copy link

@guyou guyou commented Aug 9, 2016

In order to offer the ability to create theme with advanced image galleries, nikola needs to offer a way to adds extended/manual metadata to each image files.

This feature branch add a support for additional .meta file associated to image files.

Cf. #1286

guyou added 3 commits Aug 9, 2016
Previously, once newstyle mode is detected, the metadata are read
from the initial file itself, which is wrong.
It is now possible to add a .meta file associated to any image file in
galleries. The contained metadata are made available to the gallery.tmpl.
@@ -455,6 +455,7 @@ def __init__(self, **config):
'FRONT_INDEX_HEADER': '',
'GALLERY_FOLDERS': {'galleries': 'galleries'},
'GALLERY_SORT_BY_DATE': True,
'GALLERY_USE_METADATA': True,
Copy link
Member

@ralsina ralsina Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need an option, since it's unlikely that metadata files will randomly appear next to images. If people don't want to show image metadata, then don't put meta files there :-)

Loading

Copy link
Author

@guyou guyou Aug 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I initially added this option, thinking on conflicting processing of title. But finally, I change my mind in the same way: if there is a meta file, it is the most important source of information.

I will remove that.

Loading

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 24, 2016

@guyou need a hand with anything? Want me to take over and push your work? What you have done so far is awesome, I'd love to have in Nikola!

Loading

@guyou
Copy link
Author

@guyou guyou commented Aug 26, 2016

I would appreciate to test it on a more complex "gallerie" theme, but spare time is missing. If you consider the current state meets all you requirements, so please, pull it on main branch.

Loading

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 26, 2016

@guyou awesome, I will try to give this a push this weekend and see how it goes!

Loading

@ralsina ralsina self-assigned this Aug 26, 2016
@ralsina
Copy link
Member

@ralsina ralsina commented Jun 12, 2017

I am taking over this branch and superseding the PR with a new one. Thanks for the work @guyou and sorry it took me so long to get to it.

Loading

@ralsina ralsina closed this Jun 12, 2017
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jun 12, 2017

The story continues in #2837.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants