Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rss for sections (#2068) #2463

Merged
merged 11 commits into from Aug 21, 2016
Merged

Rss for sections (#2068) #2463

merged 11 commits into from Aug 21, 2016

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Aug 20, 2016

Ouch, branched out of the wrong place. Let's not merge this without #2462 first, I don't want to have to split diffs.

Also, this has path conflicts on multilingual sites for some reason I still have not debugged.

@ralsina ralsina mentioned this pull request Aug 20, 2016

Example:

link://section_index_atom/cars => /cars/rss.xml
Copy link
Member

@Kwpolska Kwpolska Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s supposed to be section_index_rss, right?

Copy link
Member Author

@ralsina ralsina Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

El dom., ago. 21, 2016 14:45, Chris Warrick notifications@github.com
escribió:

In nikola/plugins/task/indexes.py
#2463 (comment):

@@ -296,3 +335,12 @@ def index_section_atom_path(self, name, lang):
link://section_index_atom/cars => /cars/index.atom
"""
return self.index_section_path(name, lang, is_feed=True)
+

  • def index_section_rss_path(self, name, lang):
  •    """Link to the RSS feed for a section.
    
  •    Example:
    
  •    link://section_index_atom/cars => /cars/rss.xml
    

That’s supposed to be section_index_rss, right?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/getnikola/nikola/pull/2463/files/1ccfadec9df7ed57f39c36f4525ade1243922b36#r75599839,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAGKzT1BUtMUf4bjcsdRZVy6QiaLZR2ks5qiI6dgaJpZM4Jo-MQ
.

@ralsina ralsina changed the title [WIP] Rss for sections (#2068) Rss for sections (#2068) Aug 21, 2016
@ralsina ralsina merged commit 6ff537f into master Aug 21, 2016
@ralsina ralsina deleted the rss-for-sections branch Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants