Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2472 #2480

Merged
merged 3 commits into from Aug 28, 2016
Merged

Fix #2472 #2480

merged 3 commits into from Aug 28, 2016

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Aug 28, 2016

This should not land before #2474 right?

@Kwpolska Kwpolska changed the title Fix 2472 Fix #2472 Aug 28, 2016
@@ -54,6 +54,7 @@ def register_output_name(self, input_folder, rel_name, rel_output_name):
def set_site(self, site):
"""Set Nikola site."""
site.register_path_handler('listing', self.listing_path)
site.register_path_handler('listing-source', self.listing_source_path)
Copy link
Member

@Kwpolska Kwpolska Aug 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be listing_source with an underscore for consistency.

Copy link
Member Author

@ralsina ralsina Aug 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, fixing.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Aug 28, 2016

👍

@ralsina ralsina merged commit 0a3e021 into master Aug 28, 2016
0 of 4 checks passed
@ralsina ralsina deleted the fix-2472 branch Aug 28, 2016
@ralsina ralsina restored the fix-2472 branch Aug 29, 2016
@Kwpolska Kwpolska deleted the fix-2472 branch Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants