Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting to updated version of flake8. #2563

Merged
merged 1 commit into from Nov 20, 2016
Merged

Adjusting to updated version of flake8. #2563

merged 1 commit into from Nov 20, 2016

Conversation

@felixfontein
Copy link
Contributor

felixfontein commented Nov 20, 2016

A new version of flake8 contains a new (or updated?) rule (E305) which makes Nikola fail flake8. This PR should fix it.

@felixfontein
Copy link
Contributor Author

felixfontein commented Nov 20, 2016

The baseline test is (not surprisingly) failing because:

  1. I had to change one of the source files in the example site as well;
  2. thumbnails have a different binary result than in the baseline.
Copy link
Member

Kwpolska left a comment

Thanks. Those thumbnail issues are caused by Pillow upgrades.

@Kwpolska Kwpolska merged commit 100b043 into master Nov 20, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the fixing-flake8-problems branch Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.