Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making INDEX_PATH, RSS_PATH and AUTHOR_PATH translatable #2584

Merged
merged 4 commits into from Dec 7, 2016

Conversation

@felixfontein
Copy link
Contributor

commented Dec 5, 2016

The last three checkmarks for #1914.

(fixes #1914)

@@ -73,15 +73,15 @@ def get_classification_friendly_name(self, author, lang, only_last_component=Fal

def get_overview_path(self, lang, dest_type='page'):
"""A path handler for the list of all classifications."""
return [self.site.config['AUTHOR_PATH']], 'always'
return [self.site.config['AUTHOR_PATH'][lang]], 'always'

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Dec 6, 2016

Member

Always call TranslatableSettings with (lang), never index them.

This comment has been minimized.

Copy link
@felixfontein

felixfontein Dec 6, 2016

Author Contributor

Fixed.

@@ -389,6 +389,7 @@ HIDDEN_CATEGORIES = []
# output / TRANSLATION[lang] / AUTHOR_PATH / index.html (list of tags)

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Dec 6, 2016

Member

I know this was there before, but while you’re at it, please change this to:

# Path to author pages. Final locations are:
# output / TRANSLATION[lang] / AUTHOR_PATH / index.html (list of authors)
# output / TRANSLATION[lang] / AUTHOR_PATH / author.html (list of posts by an author)
# output / TRANSLATION[lang] / AUTHOR_PATH / author.xml (RSS feed for an author)
# (translatable)

This comment has been minimized.

Copy link
@felixfontein

felixfontein Dec 6, 2016

Author Contributor

Fixed.

@felixfontein felixfontein merged commit aa45a68 into master Dec 7, 2016
5 checks passed
5 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@felixfontein felixfontein deleted the translatable-url-pathnames branch Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.