Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making INDEX_PATH, RSS_PATH and AUTHOR_PATH translatable #2584

Merged
merged 4 commits into from Dec 7, 2016

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Dec 5, 2016

The last three checkmarks for #1914.

(fixes #1914)

@@ -73,15 +73,15 @@ def get_classification_friendly_name(self, author, lang, only_last_component=Fal

def get_overview_path(self, lang, dest_type='page'):
"""A path handler for the list of all classifications."""
return [self.site.config['AUTHOR_PATH']], 'always'
return [self.site.config['AUTHOR_PATH'][lang]], 'always'
Copy link
Member

@Kwpolska Kwpolska Dec 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always call TranslatableSettings with (lang), never index them.

Copy link
Contributor Author

@felixfontein felixfontein Dec 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -389,6 +389,7 @@ HIDDEN_CATEGORIES = []
# output / TRANSLATION[lang] / AUTHOR_PATH / index.html (list of tags)
Copy link
Member

@Kwpolska Kwpolska Dec 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was there before, but while you’re at it, please change this to:

# Path to author pages. Final locations are:
# output / TRANSLATION[lang] / AUTHOR_PATH / index.html (list of authors)
# output / TRANSLATION[lang] / AUTHOR_PATH / author.html (list of posts by an author)
# output / TRANSLATION[lang] / AUTHOR_PATH / author.xml (RSS feed for an author)
# (translatable)

Copy link
Contributor Author

@felixfontein felixfontein Dec 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@felixfontein felixfontein merged commit aa45a68 into master Dec 7, 2016
@felixfontein felixfontein deleted the translatable-url-pathnames branch Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translatable URL pathnames
2 participants