Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2619 — promote Nikola in a meta generator tag #2620

Merged
merged 2 commits into from Jan 8, 2017
Merged

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Jan 8, 2017

This is #2619. cc @stefanos82.

@Kwpolska Kwpolska added this to the v7.8.2 milestone Jan 8, 2017
@Kwpolska Kwpolska requested a review from ralsina Jan 8, 2017
Copy link
Contributor

felixfontein left a comment

LGTM

@stefanos82
Copy link

stefanos82 commented Jan 8, 2017

Actually, you don't need Nikola's URL inside content; just the name is alright.

@Kwpolska
Copy link
Member Author

Kwpolska commented Jan 8, 2017

It isn’t enough, because the name alone might not drive traffic to us (name is pretty generic, and Google might not help us here)

@stefanos82
Copy link

stefanos82 commented Jan 8, 2017

Allow me to disagree so I can explain my reasoning.

The generator meta element

must not be used on pages whose markup is not generated by software, e.g. pages whose markup was written by a user in a text editor.

You can read more about it from W3's the meta element page.

Also, about traffic...you don't need to worry about it.

Here's an excerpt from Nikola's own generated HTML source code:

<meta name="author" content="The Nikola Team">
<meta property="og:site_name" content="Nikola">
<meta property="og:title" content="Static Site Generator">
<meta property="og:url" content="https://getnikola.com/index.html">
<meta property="og:description" content="Nikola — Static Site Generator
        
            
                In goes content, out comes a website, ready to deploy.
                Get started with Nikola » Learn about Nikola features »
    ">
<meta property="og:type" content="article">
<meta property="article:published_time" content="2015-07-08T09:39:34Z">
<meta name="twitter:card" content="summary">
<meta name="twitter:site" content="@GetNikola">
</head>

As you can see, the <meta property="og:url" content="https://getnikola.com/index.html"> tag directs all engines at the right direction.

@Kwpolska
Copy link
Member Author

Kwpolska commented Jan 8, 2017

og:url is the permalink to current page. It does not link to getnikola.com outside of getnikola.com.

But what do you mean with the standard excerpt? It does not say anything about linking.

@stefanos82
Copy link

stefanos82 commented Jan 8, 2017

It's not about linking, but about indicating properly what program has been used to generate the current page.

Apart from the aforementioned meta tags, inside <head> we have <link rel="canonical" href="https://getnikola.com/index.html"> that behaves the same as og:url permalink to the current page.

So, I'm pretty much sure, let alone confident that search engine bots will be able to parse the entire website and attract the appropriate traffic to Nikola.

Anyhow, if you think by adding the hyperlink inside content meta tag would help the traffic, by all means use it.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@felixfontein
Copy link
Contributor

felixfontein commented Jan 8, 2017

I think getnikola.com should definitely be included in the generator, just to resolve possible ambiguities. I like the version Nikola (getnikola.com).

@Kwpolska Kwpolska merged commit f21cd80 into master Jan 8, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the propaganda branch Jan 8, 2017
@Kwpolska
Copy link
Member Author

Kwpolska commented Jan 8, 2017

Merging, this goes into v7.8.2 which will be out soon.

@stefanos82
Copy link

stefanos82 commented Jan 9, 2017

@Kwpolska I forgot to ask: is this option going to be included in conf.py as a flag option?

I'm asking because I'm sure some folks will ask in the future how to turn it off, the same way we use expose_php = Off; in php.ini.

Not everyone want to let the public know what set of tools have they used to build their websites.

@felixfontein
Copy link
Contributor

felixfontein commented Jan 9, 2017

Currently it is enabled by default; the only way to turn it off is to edit the theme resp. create a child theme which doesn't have that meta tag set.

@stefanos82
Copy link

stefanos82 commented Jan 9, 2017

That's fine for now, but maybe in the near future we could add this option so we could avoid unnecessary headaches.

Other than that, it looks good to me. Well done mate 👍 !

@felixfontein
Copy link
Contributor

felixfontein commented Jan 9, 2017

I've created an issue so we won't forget...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.