Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling ipynb now looks for default jupyter configuration #2650

Closed
wants to merge 2 commits into from

Conversation

@knowsuchagency
Copy link
Contributor

knowsuchagency commented Jan 28, 2017

For those, like me, who use the jupyter extensions, specifically python markdown, this makes it so Nikola will automatically look to see if users have edited the configuration files nbconvert normally looks at when compiling notebooks itself.

Thus if you have a markdown cell that jupyter normally converts to 2 from {{ 1 + 1 }} in your notebook, you'll see the former rather than the later.

@@ -82,6 +82,7 @@ def _compile_string(self, nb_json):
if flag is None:
req_missing(['ipython[notebook]>=2.0.0'], 'build this site (compile ipynb)')
c = Config(self.site.config['IPYNB_CONFIG'])
c.update(get_default_jupyter_config())

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Jan 30, 2017

Member

Do not create a one-off function in nikola.utils, instead put it in ipynb.py.

@Kwpolska
Copy link
Member

Kwpolska commented Feb 4, 2017

@knowsuchagency, could you please address the review comments?

@ralsina
Copy link
Member

ralsina commented Mar 4, 2017

I followed up on the requested changes in #2688, thanks a lot for the fix @knowsuchagency :-)

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.