Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2651 -- append file name if new_post gets directory name #2663

Merged
merged 2 commits into from Feb 25, 2017
Merged

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Feb 15, 2017

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Feb 15, 2017

Wouldn't it be better to only treat the argument as a path if it ends with os.sep or /? Otherwise it is impossible to tell what nikola new_post bla does without knowing whether posts/bla is a directory or something else (a file or not even existing).

@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Feb 15, 2017

Most people would know what their directory structure is, and Nikola won’t create new directories for you.

@Kwpolska Kwpolska requested a review from ralsina Feb 16, 2017
@Kwpolska Kwpolska merged commit ca1ab1b into master Feb 25, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix-2651 branch Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants