Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.rst, add issue and PR templates #2673

Merged
merged 2 commits into from Feb 19, 2017
Merged

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Feb 17, 2017

  • Minor copyediting and content updates for CONTRIBUTING.rst.
  • Issue template which asks for environment information.
  • PR template which tells people about CONTRIBUTING.rst and what they need to do
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the Whenever milestone Feb 17, 2017
@Kwpolska Kwpolska requested review from ralsina and felixfontein Feb 17, 2017
``git pull``, please run ``git config pull.rebase true`` to prevent merges
from happening and replace them with rebase goodness. There is also an
“emergency switch” in case rebases fail and you do not know what to do:
``git pull --no-rebase``.

This comment has been minimized.

@felixfontein

felixfontein Feb 19, 2017
Contributor

Why did you remove this part about rebasing? I've always used Nikola's CONTRIBUTING.rst file to look this up when I forgot how to change the pull.rebase settings, so I will definitely miss this part ;-)

This comment has been minimized.

@Kwpolska

Kwpolska Feb 19, 2017
Author Member

added back and reworded.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM

@Kwpolska Kwpolska merged commit 90ccf74 into master Feb 19, 2017
0 of 5 checks passed
0 of 5 checks passed
codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Kwpolska Kwpolska deleted the contributing branch Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants