Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2681 -- fix crashes when rendering subcategories #2682

Merged
merged 1 commit into from Feb 26, 2017
Merged

Fix #2681 -- fix crashes when rendering subcategories #2682

merged 1 commit into from Feb 26, 2017

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Feb 25, 2017

This is #2681.

@felixfontein: I decided to remove the two extra variables, because this way we don’t have to change templates and break backwards compatibility, and those variables don’t seem useful to me — is that okay?

@Kwpolska Kwpolska added the bug label Feb 25, 2017
@Kwpolska Kwpolska added this to the v7.8.4 milestone Feb 25, 2017
@Kwpolska Kwpolska requested a review from felixfontein Feb 25, 2017
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska force-pushed the fix-2681 branch from 9f95370 to 7d837d7 Feb 25, 2017
Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM.

@Kwpolska Kwpolska merged commit c791467 into master Feb 26, 2017
5 checks passed
5 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix-2681 branch Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants