Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write nikola serve -d PID to file #2683

Merged
merged 1 commit into from Feb 26, 2017
Merged

Write nikola serve -d PID to file #2683

merged 1 commit into from Feb 26, 2017

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Feb 25, 2017

Write the PID of the detached nikola serve process to a file. If the user forgets to write the PID down, or it scrolls away, going to htop is not necessary anymore.

As an added bonus, clean up if nikola serve is killed with SIGTERM.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM. (I haven't tested this, but the code looks good.)

@Kwpolska Kwpolska merged commit c2fa5f7 into master Feb 26, 2017
5 checks passed
5 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the serve-pidfile branch Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants