Pull Request Checklist
I split actual feed generation into
In my use case, I'm building a "postcast" plugin to generate podcasts from posts. I want to add iTunes-specific tags to the podcast RSS feeds, but I didn't like the feeling of bolting domain-specific tags into the central rss renderer. My WIP plugin can now use the upstream code, but modify the result before it's written out to a file.
I've further made a small change to
Split out separate generic_rss_feed and utils.rss_writer from generic_rss_renderer. This allows generic_rss_feed and utils.rss_writer to be used by plugins to generate and write out rss feeds, but to modify them between initial generation and writing.
OK. I've added docstrings and updated CHANGES. (I'm already in AUTHORS from a previous merge.)
As an aside, I'd love for someone to look over the related plugin work I'm doing, too; but I don't know that a PR is the best place for it. Any advice?
Up to you. I'm running out of a fork that has it merged already. ;) But if it were merged upstream, one less divergence for me. Biggest problem with it, I suspect, is that it doesn't update the atom generator in kind. But I'm not using it, either, so I wouldn't have a built-in test case, either.…
On Sat, Mar 11, 2017, 4:13 PM Felix Fontein ***@***.***> wrote: Apropos: do you want to leave this PR open a bit more, or do you want to see it merged soon? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2686 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVYVhFLeCsEDUDg6TL6oi_RtpJ1pv_pks5rkyp-gaJpZM4MMprK> .