Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling ipynb now looks for default jupyter configuration #2688

Merged
merged 9 commits into from Mar 25, 2017

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Mar 4, 2017

This is a followup from #2650

For those, like @knowsuchagency, who use the jupyter extensions, specifically python markdown, this makes it so Nikola will automatically look to see if users have edited the configuration files nbconvert normally looks at when compiling notebooks itself.

Thus if you have a markdown cell that jupyter normally converts to 2 from {{ 1 + 1 }} in your notebook, you'll see the former rather than the later.

@@ -4,6 +4,7 @@ New in master
Features
--------

* Add Jupyter config as dependency for jupyter posts (by @knowsuchagency)
Copy link
Member

@Kwpolska Kwpolska Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s the purpose of this attribution?

Loading

Copy link
Member Author

@ralsina ralsina Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New contributor encouragement :-)

Loading

abs_path = os.path.join(parent, file)
with open(abs_path) as config_file:
config.update(json.load(config_file))
except FileNotFoundError:
Copy link
Member

@Kwpolska Kwpolska Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except OSError: for py2 compatibility

Loading

Copy link
Member Author

@ralsina ralsina Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Loading

@Kwpolska Kwpolska merged commit 5093999 into master Mar 25, 2017
0 of 5 checks passed
Loading
@Kwpolska Kwpolska deleted the knowsuchagency-master branch Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants