Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2690 — make date ranges work in shortcode post lists #2711

Merged
merged 1 commit into from Apr 6, 2017
Merged

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Apr 6, 2017

I implemented this as a special case in shortcodes as opposed to making
global changes, because other shortcodes may break, and I’d say that
more shortcodes would want escapes and processing done for them.

cc @felixfontein, @ralsina, @gkabbe

I implemented this as a special case in shortcodes as opposed to making
global changes, because other shortcodes may break, and I’d say that
more shortcodes would want escapes and processing done for them.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added bug minor labels Apr 6, 2017
@Kwpolska Kwpolska added this to the v7.8.5 milestone Apr 6, 2017
@Kwpolska Kwpolska requested review from ralsina and felixfontein Apr 6, 2017
Copy link
Contributor

felixfontein left a comment

LGTM.
Surely not the most elegant/generic solution (such would have their own problems, as you mentionied in #2690), but a good enough hack for this problem.

@Kwpolska Kwpolska merged commit cb5874e into master Apr 6, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix-2690 branch Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.