Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle link://category with an error #2727

Merged
merged 1 commit into from May 10, 2017
Merged

Handle link://category with an error #2727

merged 1 commit into from May 10, 2017

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Apr 19, 2017

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Fixes #2726.

Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM.

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Apr 19, 2017

fixes #2726.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 19, 2017

Add the new work e-mail address you used for this commit to your GitHub profile so your commits will appear as yours.

@@ -116,6 +116,9 @@ def slugify_tag_name(self, name, lang):

def slugify_category_name(self, path, lang):
"""Slugify a category name."""
if not path: # Probably used link://category
utils.LOGGER.error('Invalid link to a category without passing a category name. Probably meant to use category_index?')
raise ValueError()

This comment has been minimized.

@Kwpolska

Kwpolska Apr 19, 2017
Member

Perhaps we could give this exception meaningful content as well?

@ralsina ralsina merged commit 741fb2e into master May 10, 2017
1 of 5 checks passed
1 of 5 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codacy/pr Good work! A positive pull request.
Details
@Kwpolska Kwpolska deleted the fix-2726 branch May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants