Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty subarchives #2735

Merged
merged 2 commits into from May 7, 2017
Merged

Avoid empty subarchives #2735

merged 2 commits into from May 7, 2017

Conversation

@felixfontein
Copy link
Contributor

felixfontein commented Apr 24, 2017

Fixes #2734.

Some archive pages are no longer created (more precisely: empty pages on month and year level), so strictly speaking this is breaking backwards compatibility.

@Kwpolska Kwpolska requested a review from ralsina Apr 24, 2017
Copy link
Member

Kwpolska left a comment

I’d consider this “breaks backwards compatibility, but compatibility with something dumb isn’t worth it”. LGTM.

@felixfontein
Copy link
Contributor Author

felixfontein commented Apr 25, 2017

I agree. Should we wait for @ralsina, or merge now?

@Kwpolska
Copy link
Member

Kwpolska commented Apr 26, 2017

Let’s wait.

@felixfontein
Copy link
Contributor Author

felixfontein commented May 7, 2017

@ralsina: can you take a look at this PR?

@ralsina
Copy link
Member

ralsina commented May 7, 2017

LGTM

@ralsina ralsina merged commit ef84f85 into master May 7, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the avoid-empty-subarchives branch May 7, 2017
@felixfontein
Copy link
Contributor Author

felixfontein commented May 7, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.