Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2758 -- Add support for theme meta files #2768

Merged
merged 1 commit into from May 17, 2017
Merged

Fix #2758 -- Add support for theme meta files #2768

merged 1 commit into from May 17, 2017

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 15, 2017

This is #2758. Nikola currently only uses the parent and engine values, and the themes site does not have support for these files yet. (We could also add something like MinVersion/MaxVersion support).

Old themes (without .meta files) are still supported and should work without changes.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member

@ralsina ralsina commented May 15, 2017

LGTM very superficial review

@ralsina ralsina merged commit 9e8dd6d into master May 17, 2017
5 checks passed
@ralsina ralsina deleted the theme-ini branch May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants