Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowr no jquery #2776

Merged
merged 3 commits into from May 19, 2017
Merged

Flowr no jquery #2776

merged 3 commits into from May 19, 2017

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented May 19, 2017

This branch makes Flowr.js work without JQuery, and in the base theme. Therefore:

  • The base gallery looks more like the bootstrap gallery
  • All themes derived from base get a nicer gallery

I am hesitant to make the bootstrap theme use this, since it may break someone's derived theme.

@Kwpolska
Copy link
Member

Kwpolska commented May 19, 2017

@ralsina flowr.js should be a symlink. Otherwise, it’s not kept up-to-date with Bower, and stuff like this happens.

@ralsina
Copy link
Member Author

ralsina commented May 19, 2017

@Kwpolska updated from where? It's basically a fork at this point.

@Kwpolska
Copy link
Member

Kwpolska commented May 19, 2017

Wait, so you hacked flowr not to require jQuery?

@ralsina
Copy link
Member Author

ralsina commented May 19, 2017

Exactly :-)

@Kwpolska
Copy link
Member

Kwpolska commented May 19, 2017

IMO it’d be better to focus on #2777 than use a stop-gap measure. But if you want this now, feel free to merge with no-reviews override.

@ralsina
Copy link
Member Author

ralsina commented May 19, 2017

That's also happening soon, it's orthogonal. Merging, then.

@ralsina ralsina merged commit 8a98477 into master May 19, 2017
@ralsina ralsina deleted the flowr-no-jquery branch May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants