Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BaguetteBox in base theme #2791

Merged
merged 26 commits into from May 25, 2017
Merged

Use BaguetteBox in base theme #2791

merged 26 commits into from May 25, 2017

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented May 22, 2017

This adds a nice, lightweight lightbox to the base theme.

Very conservative branch: no changes in bootstrap3, no captions, just the very barebones support.

ralsina added 4 commits May 22, 2017
@@ -20,7 +20,13 @@ ${template_hooks['extra_head']()}
${footer.html_footer()}
</div>
${base.late_load_js()}
% if use_cdn:
<script src="//cdnjs.cloudflare.com/ajax/libs/baguettebox.js/1.8.2/baguetteBox.min.js"></script>

This comment has been minimized.

@Kwpolska

Kwpolska May 22, 2017
Member

https://

This comment has been minimized.

@ralsina

ralsina May 22, 2017
Author Member

This keeps it protocol-relative, is https better? It used to give a mixed-content warning :-P

This comment has been minimized.

@Kwpolska

Kwpolska May 22, 2017
Member

protocol-relative stopped being cool a while back. Using httpS never gave mixed-content warnings, only http did.

This comment has been minimized.

@ralsina

ralsina May 22, 2017
Author Member

Ok, https it is

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 22, 2017

Are captions supported if we wanted them?

@ralsina
Copy link
Member Author

@ralsina ralsina commented May 22, 2017

@Kwpolska yes, they are

ralsina added 9 commits May 22, 2017
nah
@ralsina
Copy link
Member Author

@ralsina ralsina commented May 24, 2017

I have NO IDEA why this is failing.

ralsina added 13 commits May 25, 2017
wtf
wtf
wtf
wtf
@ralsina ralsina merged commit b8808c2 into master May 25, 2017
1 of 5 checks passed
1 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
codacy/pr Good work! A positive pull request.
Details
@ralsina ralsina deleted the baguette branch May 25, 2017
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 25, 2017

(PS. CSSLint is pretty crazy, so I nuked it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.