Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess locale using locale.getdefaultlocale() #2795

Merged
merged 4 commits into from May 24, 2017
Merged

Guess locale using locale.getdefaultlocale() #2795

merged 4 commits into from May 24, 2017

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 24, 2017

Credit for discovering this goes to @madduck. Will avoid some more “cannot guess locale” errors.

Kwpolska added 3 commits May 24, 2017
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.8.6 milestone May 24, 2017
@Kwpolska Kwpolska requested review from ralsina and ccanepa May 24, 2017
@madduck
Copy link

@madduck madduck commented May 24, 2017

Thanks for the quick turnaround. I've tested this with a mix of en_NZ.UTF-8 and de_DE.UTF-8 and it does what it should.

[ci skip]

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina ralsina merged commit 938d105 into master May 24, 2017
1 check passed
1 check passed
codacy/pr Good work! A positive pull request.
Details
@ralsina ralsina deleted the sane-locale-guesses branch May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants