Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON metadata #2804

Merged
merged 1 commit into from May 28, 2017

Conversation

@ralsina
Copy link
Member

commented May 28, 2017

Naive JSON metadata support (Issue #2801)

@ralsina ralsina merged commit 574621f into master May 28, 2017
5 checks passed
5 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the json-metadata branch May 28, 2017
@@ -1053,6 +1053,16 @@ def _get_metadata_from_file(meta_data):
meta = toml.load('\n'.join(meta_data[1:idx]))
return meta

# If 1st line is '{', then it's JSON metadata

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska May 29, 2017

Member

ipynb files also start with {. This might need extra handling in some cases (are we likely to reach this function with 1-file ipynb files that have Nikola-specific metadata already?)

This comment has been minimized.

Copy link
@ralsina

ralsina May 29, 2017

Author Member

I don't know, really, but I can try to see :-)

@Kwpolska

This comment has been minimized.

Copy link
Member

commented May 29, 2017

Note: This feature was withdrawn in commit 2623322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.