Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metadata mapping #2820

Merged
merged 5 commits into from Jun 4, 2017
Merged

Implement metadata mapping #2820

merged 5 commits into from Jun 4, 2017

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 4, 2017

Kwpolska added 4 commits Jun 4, 2017
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.8.7 milestone Jun 4, 2017
@Kwpolska Kwpolska requested review from ralsina and felixfontein Jun 4, 2017
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM

nikola/utils.py Outdated
"""Map metadata from other platforms to Nikola names.

This uses the METADATA_MAPPING setting (via ``config``) and modifies the dict in place."""
for foreign, ours in config['METADATA_MAPPING'].get(key, {}).items():
Copy link
Contributor

@felixfontein felixfontein Jun 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config can be None, when _get_metadata_from_file is called without config specified.

Copy link
Member Author

@Kwpolska Kwpolska Jun 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point (although it’s very unlikely). Fixed on master.

ralsina
ralsina approved these changes Jun 4, 2017
@ralsina ralsina merged commit 253ecfa into master Jun 4, 2017
@ralsina ralsina deleted the meta-mapping branch Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants