Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis testing for OSX and fix locale tests. #2824

Merged
merged 1 commit into from Jun 6, 2017
Merged

Add travis testing for OSX and fix locale tests. #2824

merged 1 commit into from Jun 6, 2017

Conversation

@gwax
Copy link
Contributor

@gwax gwax commented Jun 6, 2017

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Fix locale tests on OSX and add OSX build to Travis.

Copy link
Member

@Kwpolska Kwpolska left a comment

👍, but I’m not sure about the install method.

Also, I genuinely did not expect this:

>> Testing baseline...
>> Baseline test successful

Loading

env: NMODE=nikola
python: '3.6'
before_install:
- brew upgrade pyenv
Copy link
Member

@Kwpolska Kwpolska Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not brew install python3; brew link python3? I’m not a fan of pyenv myself, and the Homebrew python is pretty good. Plus, it doesn’t need to be updated to track Python patch versions (and minor versions, too)

Loading

Copy link
Contributor Author

@gwax gwax Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that but it doesn't provide any control over which specific version of python is running and it means that changes in Homebrew could unexpectedly break builds.

The crux of it is that Travis support for Python builds on macOS is a little lacking and this was the simplest, reliable, reproducible way that I could come up with to get things to build (there are a lot of failed attempts squashed into this commit).

Loading

Copy link
Member

@Kwpolska Kwpolska Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could argue the same about Travis CI’s images (in fact, I had to take down a C project of mine because Travis introduced random crashes I can’t debug in any way).

I’m going to merge this and experiment using Python from Homebrew. (and if it breaks, I’ll be the first to know as that’s how I’m working on my Mac).

Loading

Copy link
Contributor Author

@gwax gwax Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, I was also not a fan of pyenv for quite a while but pyenv-virtualenv combined with pyenv local has really brought me around.

Loading

CHANGES.txt Outdated
@@ -47,6 +47,7 @@ Bugfixes

* Use inheritance tree when looking for theme engine (Issue #2816)
* Fix unbound variable error in locale guessing (Issue #2806)
* Tests run on OSX.
Copy link
Member

@Kwpolska Kwpolska Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into “New in master”, I’ll fix it when merging.

(PS. macOS*)

Loading

Copy link
Contributor Author

@gwax gwax Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Loading

@Kwpolska Kwpolska merged commit 5b339f3 into getnikola:master Jun 6, 2017
0 of 3 checks passed
Loading
@gwax gwax deleted the osx_testing branch Jun 6, 2017
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jun 6, 2017

There's one disadvantage for Travis macOS builds: they take forever to start. Take a look at the OSX Build Backlog here: https://www.traviscistatus.com/

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants