Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3 from Homebrew for macOS Travis builds #2828

Merged
merged 1 commit into from Jun 8, 2017

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 7, 2017

cc @gwax, @felixfontein — I think this will be better, but feel free to disagree

I’ll merge this if nobody complains by Friday morning (UTC).

@Kwpolska Kwpolska changed the title Use Python 3 from Homebrew Use Python 3 from Homebrew for macOS Travis builds Jun 7, 2017
.travis.yml Outdated
- pip3 install virtualenv
- python3 -m virtualenv nikola-tests-venv
- source nikola-tests-venv/bin/activate
- pip install --upgrade pip
Copy link
Contributor

@gwax gwax Jun 7, 2017

For parity with before_install: on the linux builds, this last line should probably be:

- pip install --upgrade pip wheel

Copy link
Member Author

@Kwpolska Kwpolska Jun 7, 2017

Good point, fixed.

@@ -20,13 +20,14 @@ matrix:
include:
- os: osx
language: generic
env: NMODE=nikola
env: NMODE=nikola OS=macOS
Copy link
Contributor

@gwax gwax Jun 7, 2017

The apple vs penguin icons aren't enough?

Copy link
Member Author

@Kwpolska Kwpolska Jun 7, 2017

They’re hard to spot, especially if you’ve never looked there before (and the icons are barely-visible grey)

Copy link
Contributor

@gwax gwax Jun 7, 2017

I asked the question expecting (and largely agreeing with) that answer.

gwax
gwax approved these changes Jun 7, 2017
Copy link
Contributor

@gwax gwax left a comment

LGTM

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska force-pushed the travis-homebrew-python branch from a3c8487 to 8abf6b7 Jun 8, 2017
@Kwpolska Kwpolska merged commit 10334b6 into master Jun 8, 2017
5 checks passed
@Kwpolska Kwpolska deleted the travis-homebrew-python branch Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants