Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image captions (Part of #2777) #2829

Merged
merged 2 commits into from Jun 10, 2017
Merged

image captions (Part of #2777) #2829

merged 2 commits into from Jun 10, 2017

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 7, 2017

  • Use alt attribute for lightbox captions
  • Set alt attribute to image title in base theme galleries.
@ralsina
Copy link
Member Author

@ralsina ralsina commented Jun 7, 2017

This seems to fail on windows because of some missing symlinks? Any ideas @Kwpolska ?

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 8, 2017

Fixed (I deleted some useless unminified files and hadn’t updated the symlinked list when you branched out)

Copy link
Member

@Kwpolska Kwpolska left a comment

LGTM

@ralsina ralsina merged commit ede1b13 into master Jun 10, 2017
5 checks passed
5 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the baguette-captions branch Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.